Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/23012 )
Change subject: IMPALA-9874: Skip IO for late materialized columns ...................................................................... Patch Set 9: (3 comments) > Patch Set 8: > > (4 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/23012/8/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23012/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@259 PS8, Line 259: late_materialization_ = !(filter_readers_.empty() || non_filter_readers_.empty() : || late_materialization_threshold_ < 0 || filter_readers_[0]->max_rep_level() > 0 : || HasStructColumnReader(non_filter_readers_)); > optional: This complex condition + the logic in line 269-274 could have its Thanks! I am also trying to understand the condition `filter_readers_[0]->max_rep_level() > 0` . http://gerrit.cloudera.org:8080/#/c/23012/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@2464 PS8, Line 2464: int num_row_to_commit = FilterScratchBatch(row_batch); : if (rows_selected_in_row_group_ && !non_filter_scalar_readers_started_) { : RETURN_IF_ERROR(BaseScalarColumnReader::StartScans(non_filter_scalar_readers_)); : RETURN_IF_ERROR( : > I would prefer to have an extra bool (e.g. non_filter_scalar_readers_starte Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/23012/8/be/src/exec/scratch-tuple-batch.h File be/src/exec/scratch-tuple-batch.h: http://gerrit.cloudera.org:8080/#/c/23012/8/be/src/exec/scratch-tuple-batch.h@139 PS8, Line 139: keep_aux_mem > if keep_aux_mem is false, then num_to_commit must be false, right? if yes, Thanks! Added a DCHECK. -- To view, visit http://gerrit.cloudera.org:8080/23012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a052b028220517503e634e3f916d1fbd60eb65d Gerrit-Change-Number: 23012 Gerrit-PatchSet: 9 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 19 Aug 2025 09:12:00 +0000 Gerrit-HasComments: Yes
