Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23060 )
Change subject: IMPALA-14175: Generate impala-udf-devel package using the build script ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/23060/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23060/2//COMMIT_MSG@14 PS2, Line 14: - Tested that rpm is generated using build script: : ./buildall.sh -release_and_debug -skiptests -udf_devel_package : - Tested that the rpm is also generated using standalone script: : ./bin/make-impala-udf-devel-rpm.sh > Is this only work when building using RHEL/Centos machine? Please clarify. What about ARM architectures? http://gerrit.cloudera.org:8080/#/c/23060/2/bin/make-impala-udf-devel-rpm.sh File bin/make-impala-udf-devel-rpm.sh: http://gerrit.cloudera.org:8080/#/c/23060/2/bin/make-impala-udf-devel-rpm.sh@1 PS2, Line 1: #!/bin/bash This file needs to be marked executable (chmod 755) http://gerrit.cloudera.org:8080/#/c/23060/2/bin/make-impala-udf-devel-rpm.sh@54 PS2, Line 54: skiptests Nit: change to notests http://gerrit.cloudera.org:8080/#/c/23060/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/23060/2/buildall.sh@305 PS2, Line 305: -skiptests -notests would be better because that skips building and running all tests. -skiptests only skips running the tests, but they are still built. http://gerrit.cloudera.org:8080/#/c/23060/2/buildall.sh@305 PS2, Line 305: " Delete extra doublequote -- To view, visit http://gerrit.cloudera.org:8080/23060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b85df9c3f680a7e5551f067a97a5650daba9b50 Gerrit-Change-Number: 23060 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 23:09:59 +0000 Gerrit-HasComments: Yes
