Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23060 )
Change subject: IMPALA-14175: Generate impala-udf-devel package using the build script ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/23060/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23060/2//COMMIT_MSG@14 PS2, Line 14: - Tested that rpm is generated using build script: : ./buildall.sh -release_and_debug -notests -udf_devel_package : - Tested that the rpm is also generated using standalone script: : ./bin/make-impala-udf-devel-rpm.sh > What about ARM architectures? Yes, tested building on arm. http://gerrit.cloudera.org:8080/#/c/23060/2//COMMIT_MSG@14 PS2, Line 14: - Tested that rpm is generated using build script: : ./buildall.sh -release_and_debug -notests -udf_devel_package : - Tested that the rpm is also generated using standalone script: : ./bin/make-impala-udf-devel-rpm.sh > Is this only work when building using RHEL/Centos machine? Please clarify. It should work on all our supported platforms. I've only built and tested on Ubuntu 22.04 and Rhel 9. http://gerrit.cloudera.org:8080/#/c/23060/2/bin/make-impala-udf-devel-rpm.sh File bin/make-impala-udf-devel-rpm.sh: http://gerrit.cloudera.org:8080/#/c/23060/2/bin/make-impala-udf-devel-rpm.sh@1 PS2, Line 1: #!/bin/bash > This file needs to be marked executable (chmod 755) Done http://gerrit.cloudera.org:8080/#/c/23060/2/bin/make-impala-udf-devel-rpm.sh@54 PS2, Line 54: skiptests > Nit: change to notests Done http://gerrit.cloudera.org:8080/#/c/23060/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/23060/2/buildall.sh@305 PS2, Line 305: -notests - > -notests would be better because that skips building and running all tests. Yeah for this purpose `notests` probably makes sense. http://gerrit.cloudera.org:8080/#/c/23060/2/buildall.sh@305 PS2, Line 305: > Delete extra doublequote They are needed for the multi line comment -- To view, visit http://gerrit.cloudera.org:8080/23060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b85df9c3f680a7e5551f067a97a5650daba9b50 Gerrit-Change-Number: 23060 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 06 Sep 2025 02:05:26 +0000 Gerrit-HasComments: Yes
