Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23343 )
Change subject: IMPALA-14348: Fix TSAN issue after IMPALA-14327 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/23343/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/23343/3/be/src/service/impala-hs2-server.cc@648 PS3, Line 648: } I think that the current solution is not perfect, ideally we should block the async part of query from finishing before ExecuteStatement is finished - the current solution is hard to reason about, e.g. what happens of the DDL is finished before reaching SetQueryInflight(). Also discussed this with Riza on another channel. As the current state can hide other issues from TSAN, I am ok with merging this, but preferably there should be a follow up commit to clean this up. -- To view, visit http://gerrit.cloudera.org:8080/23343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fc25cea5b4ef7b4b9daac54b8665fa76ceb1cd Gerrit-Change-Number: 23343 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 14:44:43 +0000 Gerrit-HasComments: Yes
