Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23343 )
Change subject: IMPALA-14348: Fix TSAN issue after IMPALA-14327 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23343/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/23343/3/be/src/service/impala-hs2-server.cc@673 PS3, Line 673: *result_set_md, nullptr, query_handle->query_options().stringify_map_keys, 0); This line creates a copy of result_set_md. Could we create the copy inside the lock, but then call CreateHS2ResultSet after releasing it? -- To view, visit http://gerrit.cloudera.org:8080/23343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fc25cea5b4ef7b4b9daac54b8665fa76ceb1cd Gerrit-Change-Number: 23343 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Aug 2025 22:56:45 +0000 Gerrit-HasComments: Yes
