Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23342 )
Change subject: POC IMPALA-13125: Fix pairwise test vector generation ...................................................................... Patch Set 3: (18 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_dimensions.py@70 PS3, Line 70: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_dimensions.py@73 PS3, Line 73: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@63 PS3, Line 63: import random flake8: F401 'random' imported but unused http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@260 PS3, Line 260: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@261 PS3, Line 261: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@263 PS3, Line 263: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@266 PS3, Line 266: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@268 PS3, Line 268: s flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@269 PS3, Line 269: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@269 PS3, Line 269: e flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@270 PS3, Line 270: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@271 PS3, Line 271: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@279 PS3, Line 279: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@280 PS3, Line 280: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/common/test_vector.py@284 PS3, Line 284: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/query_test/test_decimal_queries.py File tests/query_test/test_decimal_queries.py: http://gerrit.cloudera.org:8080/#/c/23342/3/tests/query_test/test_decimal_queries.py@48 PS3, Line 48: : flake8: E231 missing whitespace after ':' http://gerrit.cloudera.org:8080/#/c/23342/3/tests/query_test/test_decimal_queries.py@48 PS3, Line 48: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/23342/3/tests/query_test/test_decimal_queries.py@49 PS3, Line 49: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/23342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Gerrit-Change-Number: 23342 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 13:23:18 +0000 Gerrit-HasComments: Yes
