Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23342 )
Change subject: POC IMPALA-13125: Fix pairwise test vector generation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23342/1/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/23342/1/tests/common/test_vector.py@306 PS1, Line 306: __pairwise_step > Can we create test under tests/infra/ to compare the difference between thi Yes, some test would be nice, but it is a bit tricky, because allpairspy was very sensitive to input and filter, so it is not clear what to test. I kind of lost confidence in allpairspy, especially as there is an open issue and PR about a similar problem. There is one newer version than ours, 1.5.1. My focus now is on seeing the effects of this on Impala tests (waiting for an exhaustive run), e.g. does it become much slower due to the larger vector set. -- To view, visit http://gerrit.cloudera.org:8080/23342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Gerrit-Change-Number: 23342 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 24 Aug 2025 17:24:29 +0000 Gerrit-HasComments: Yes
