Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23311 )
Change subject: IMPALA-14101: [part 2] Calcite planner: Add cost model calculations ...................................................................... Patch Set 2: Code-Review+1 (2 comments) I just have some nits that I want to see in commit message, mainly to educate myself. http://gerrit.cloudera.org:8080/#/c/23311/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23311/2//COMMIT_MSG@9 PS2, Line 9: This commit adds the cost model and calculations to be used in the join : optimizer rule. nit: Please help with short explanation on how this costing will impact resulting plan. For example, what does it mean when a join plan has a big cost? Are they placed lower in query plan, or, are different join plan will be considered? http://gerrit.cloudera.org:8080/#/c/23311/2//COMMIT_MSG@16 PS2, Line 16: The ImpalaCost object is generated in the ImpalaRelMdNonCumulativeCost : class which is called from Calcite for a given RelNode. nit: Please mention a bit about which query operator that has implemented custom costing from this patch. I see Scan, Aggregation, Join. Anything else planned? Is this costing specific to single node plan (ie., not used for BROADCAST vs HASH decision)? -- To view, visit http://gerrit.cloudera.org:8080/23311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e52b0e11e9a6d5814b0313117dd9c56602f3ff5 Gerrit-Change-Number: 23311 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 20 Aug 2025 17:43:33 +0000 Gerrit-HasComments: Yes
