Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23311 )
Change subject: IMPALA-14101: Calcite planner: Add cost model calculations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23311/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java: http://gerrit.cloudera.org:8080/#/c/23311/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdNonCumulativeCost.java@43 PS1, Line 43: The base code was copied from the Hive code base > Can you add link to Hive code that this ImpalaRelMdNonCumulativeCost is bas I don't have the specific version, but the code here has changed enough where I'm not sure it's necessary. In some of the other patches, I've included the original link, but that's because I really wanted to avoid having the reviewer trying to understand parts that were directly from Calcite and have already undergone Calcite review. Here, there really isn't that much code, and I think the whole file should be reviewed. -- To view, visit http://gerrit.cloudera.org:8080/23311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e52b0e11e9a6d5814b0313117dd9c56602f3ff5 Gerrit-Change-Number: 23311 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 20 Aug 2025 15:00:44 +0000 Gerrit-HasComments: Yes
