Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23190 )
Change subject: IMPALA-14237: Fix Iceberg partition values encoding ...................................................................... Patch Set 7: (3 comments) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/util/coding-util.cc@43 PS7, Line 43: .-*_ Why did the characters change? Please add explanation to the commit message. http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/util/coding-util.cc@70 PS7, Line 70: !ShouldNotEscape nit: we could avoid double-negation if we can make ShouldNotEscape() -> ShouldEscape() http://gerrit.cloudera.org:8080/#/c/23190/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test: http://gerrit.cloudera.org:8080/#/c/23190/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test@1104 PS7, Line 1104: select * from unicode_truncate; Please add SELECT statements with WHERE clause to test partition pruning works fine. -- To view, visit http://gerrit.cloudera.org:8080/23190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabb39727f6dd49b76c918bcd6b3ec62532555755 Gerrit-Change-Number: 23190 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Aug 2025 10:52:30 +0000 Gerrit-HasComments: Yes
