Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23190 )
Change subject: IMPALA-14237: Fix Iceberg partition values encoding ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23190/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23190/7//COMMIT_MSG@14 PS7, Line 14: Also, for an Iceberg table UrlEncode is called in not the Hive-compatible : way, rather than the standard way, similar to Java's URLEncoder.encode() : (which the Iceberg API also uses). Is this an actual functional bug, or just a conforming with a convention? My understanding is that the actual paths used do not matter in Iceberg. http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/exprs/iceberg-functions-ir.cc File be/src/exprs/iceberg-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/exprs/iceberg-functions-ir.cc@105 PS7, Line 105: if (input.len <= width.val) return input; Can you add a comment that this is always utf8 regardless of utf8_mode? -- To view, visit http://gerrit.cloudera.org:8080/23190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabb39727f6dd49b76c918bcd6b3ec62532555755 Gerrit-Change-Number: 23190 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 12 Aug 2025 06:22:24 +0000 Gerrit-HasComments: Yes
