Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23158 )
Change subject: IMPALA-14214: Compile OpenTelemetry-cpp Against STDLIB ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23158/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23158/3//COMMIT_MSG@10 PS3, Line 10: ABI compatibility is not needed. Thus, take advantage of the > nit: this isn't actually related to whether we use static or dynamic librar Good observation, I reworded the commit message to better explain what is going on. http://gerrit.cloudera.org:8080/#/c/23158/3/source/opentelemetry-cpp/build.sh File source/opentelemetry-cpp/build.sh: http://gerrit.cloudera.org:8080/#/c/23158/3/source/opentelemetry-cpp/build.sh@47 PS3, Line 47: wrap make -j${BUILD_THREADS:-4} > Can I tack on something unrelated? Can you add VERBOSE=1 for this make invo Done -- To view, visit http://gerrit.cloudera.org:8080/23158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c1b70a529d8211c31ba1019d6e9e34b4d3a91f3 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 17 Jul 2025 23:23:54 +0000 Gerrit-HasComments: Yes
