Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23158 )
Change subject: IMPALA-14214: Compile OpenTelemetry-cpp Against STDLIB ...................................................................... Patch Set 3: Code-Review+1 (1 comment) This looks good to me. Something unrelated that we can fix if that's ok. http://gerrit.cloudera.org:8080/#/c/23158/3/source/opentelemetry-cpp/build.sh File source/opentelemetry-cpp/build.sh: http://gerrit.cloudera.org:8080/#/c/23158/3/source/opentelemetry-cpp/build.sh@47 PS3, Line 47: wrap make -j${BUILD_THREADS:-4} Can I tack on something unrelated? Can you add VERBOSE=1 for this make invocation? i.e. wrap make VERBOSE=1 -j${BUILD_THREADS:-4} The verbose mode shows the compilation commands as part of the output. It makes it easier to verify that compilation flags are doing what we expect. -- To view, visit http://gerrit.cloudera.org:8080/23158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c1b70a529d8211c31ba1019d6e9e34b4d3a91f3 Gerrit-Change-Number: 23158 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 17 Jul 2025 22:11:32 +0000 Gerrit-HasComments: Yes
