Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22799 )
Change subject: IMPALA-13824: Add unit tests for PlanToJson ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Only found nits, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/22799/9/be/src/service/impala-http-handler-test.cc File be/src/service/impala-http-handler-test.cc: http://gerrit.cloudera.org:8080/#/c/22799/9/be/src/service/impala-http-handler-test.cc@347 PS9, Line 347: nit: please remove empty line, we usually don't put empty lines between function comments and function definitions so it's clear that the comment belongs to the function http://gerrit.cloudera.org:8080/#/c/22799/9/be/src/service/impala-http-handler-test.cc@455 PS9, Line 455: nit: unnecessary empty line -- To view, visit http://gerrit.cloudera.org:8080/22799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b7f2b3a914c9091db51fbed117a80330f1d6fe5 Gerrit-Change-Number: 22799 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jun 2025 14:02:06 +0000 Gerrit-HasComments: Yes
