Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/22799 )
Change subject: IMPALA-13824: add unit tests for PlanToJson ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/22799/5/be/src/service/impala-http-handler-test.cc File be/src/service/impala-http-handler-test.cc: http://gerrit.cloudera.org:8080/#/c/22799/5/be/src/service/impala-http-handler-test.cc@199 PS5, Line 199: }, : "num_instances": { : "type": "integer" : }, > These could be local to TEST_F(ImpalaHttpHandlerTest, SelectStatement). Done http://gerrit.cloudera.org:8080/#/c/22799/5/be/src/service/impala-http-handler-test.cc@204 PS5, Line 204: "const": "true" > Could you please add a comment about how the plan will look like? And what Done http://gerrit.cloudera.org:8080/#/c/22799/5/be/src/service/impala-http-handler-test.cc@222 PS5, Line 222: "type": "string" > One more test that has a JOIN of two tables would be nice. Done -- To view, visit http://gerrit.cloudera.org:8080/22799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b7f2b3a914c9091db51fbed117a80330f1d6fe5 Gerrit-Change-Number: 22799 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Jun 2025 14:30:18 +0000 Gerrit-HasComments: Yes
