Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22215 )
Change subject: IMPALA-13478: Sync tuple cache files to disk asynchronously ...................................................................... Patch Set 10: > I ran the ASAN and TSAN build, the TestOutstandingWriteLimitConcurrent > seems flaky. > 21:26:42 [ RUN ] TupleCacheMgrTest.TestOutstandingWriteLimitConcurrent > 21:26:42 > /data/jenkins/workspace/impala-private-parameterized/repos/Impala/be/src/runtime/tuple-cache-mgr-test.cc:449: > Failure > 21:26:42 Expected: (cache.tuple_cache_backpressure_halted_->GetValue()) > > (0), actual: 0 vs 0 > 21:26:42 > 21:26:42 [ FAILED ] TupleCacheMgrTest.TestOutstandingWriteLimitConcurrent > (21 ms) That assertion is not something that we can guarantee, so I removed it. -- To view, visit http://gerrit.cloudera.org:8080/22215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646bb56300656d8b8ac613cb8fe2f85180b386d3 Gerrit-Change-Number: 22215 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 22 May 2025 18:18:54 +0000 Gerrit-HasComments: No
