Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22215 )
Change subject: IMPALA-13478: Sync tuple cache files to disk asynchronously ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22215/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22215/8//COMMIT_MSG@44 PS8, Line 44: - number of sync calls that fail (due to IO errors) > Done Ack http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr.cc File be/src/runtime/tuple-cache-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr.cc@441 PS8, Line 441: bool success = sync_thread_pool_->Offer(cache_->Key(handle->cache_handle).ToString()); > Done Ack -- To view, visit http://gerrit.cloudera.org:8080/22215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646bb56300656d8b8ac613cb8fe2f85180b386d3 Gerrit-Change-Number: 22215 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 21 May 2025 21:32:25 +0000 Gerrit-HasComments: Yes