Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22883 )
Change subject: IMPALA-13982: [WIP] Support views for Calcite planner in Impala ...................................................................... Patch Set 4: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22883/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/22883/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@140 PS4, Line 140: HdfsTable table = (HdfsTable) calciteTable.getHdfsTable(); // fang-yu: the lhs is not actually used. line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22883/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/22883/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@173 PS4, Line 173: dbSchemas.getOrDefault(tableName.getDb().toUpperCase(), new CalciteDb.Builder(reader)); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22883/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@201 PS4, Line 201: // we need to set 'modifiable' to false instead of null to pass the query validation. line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22883/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@208 PS4, Line 208: schema.plus().add(feTable.getName().toUpperCase(), viewTableMacro); // fang-yu: try uppercase it too. line too long (109 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893 Gerrit-Change-Number: 22883 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 13 May 2025 00:36:27 +0000 Gerrit-HasComments: Yes
