Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22883
to look at the new patch set (#2).
Change subject: IMPALA-13982: [WIP] Support views for Calcite planner in Impala
......................................................................
IMPALA-13982: [WIP] Support views for Calcite planner in Impala
This patch adds the support for regular views for the Calcite planner
via adding a ViewTableMacro for each regular view in the given query
when populating the Calcite schema.
To be able to expand the view in ViewTableMacro, we need a newer
version of protobuf-java, e.g., 3.21.12. Currently 2.5.0 is
transitively pulled in by org.apache.hadoop:hadoop-hdfs. To address
this issue, based on the suggestion from Stamatis Zampetakis, we
exclude avatica-core from the artifacts that are pulled in by
calcite-core, and explicitly add avatica as a dependency, which already
shades the protobuf-java it requires to expand a view.
The patch supports the following cases, where functional.alltypes_view
is a regular view defined as "SELECT * FROM functional.alltypes".
1. select id from functional.alltypes_view
2. select alltypes_view.id from functional.alltypes_view;
3. select functional.alltypes_view.id from functional.alltypes_view;
Note that authorization for views is not yet supported.
Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java
M java/calcite-planner/pom.xml
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java
A java/calcite-planner/src/main/java/org/apache/impala/calcite/sql/SqlView.java
11 files changed, 290 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/22883/2
--
To view, visit http://gerrit.cloudera.org:8080/22883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893
Gerrit-Change-Number: 22883
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
