Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22847 )
Change subject: IMPALA-12201: Stabilize TestFetch ...................................................................... Patch Set 4: (2 comments) We need an explicit close for the MinimalHS2Connection or the session will leak and cause issues with verifiers/test_verify_metrics.py http://gerrit.cloudera.org:8080/#/c/22847/4/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/22847/4/tests/query_test/test_fetch.py@93 PS4, Line 93: client = MinimalHS2Connection(IMPALAD_HS2_HOST_PORT) This client needs an explicit close call before the end of this test function. i.e. at the end (after fetching profile): client.close() http://gerrit.cloudera.org:8080/#/c/22847/4/tests/query_test/test_fetch.py@130 PS4, Line 130: client = MinimalHS2Connection(IMPALAD_HS2_HOST_PORT) Same as above, need an explicit close for this client. -- To view, visit http://gerrit.cloudera.org:8080/22847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52651df37a318357711d26d2414e025cce4185c3 Gerrit-Change-Number: 22847 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Tue, 06 May 2025 16:17:45 +0000 Gerrit-HasComments: Yes
