Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22847 )
Change subject: IMPALA-12201: Stabilize TestFetch ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22847/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22847/1/tests/common/impala_connection.py@1155 PS1, Line 1155: def wait_for_finished_timeout(self, operation_handle, timeout): : start_time = time.time() > Nit: get_operation_status() here is the same as get_state() Removed. http://gerrit.cloudera.org:8080/#/c/22847/1/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/22847/1/tests/query_test/test_fetch.py@92 PS1, Line 92: num_rows = 27 > Nit: This comment is out of date Removed. http://gerrit.cloudera.org:8080/#/c/22847/1/tests/query_test/test_fetch.py@147 PS1, Line 147: # ImpylaHS2Connection.close_query(). Need to do this manually because : # MinimalHS2Connection.close_query() does not automatically do that. : result = client.fetch(que > This test is intentionally not fetching all the way. What happens if we don Right. With proper client, the close operation will try to do one more fetch. This is added to simulate that behavior using MinimalHS2Connection that does not automatically do that. With this, assertions in L159 and L161 does not need to change. -- To view, visit http://gerrit.cloudera.org:8080/22847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52651df37a318357711d26d2414e025cce4185c3 Gerrit-Change-Number: 22847 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 02 May 2025 20:22:16 +0000 Gerrit-HasComments: Yes
