Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22855 )
Change subject: IMPALA-14030: Fix buffer underflow when base64 decoding 0 length binaries ...................................................................... IMPALA-14030: Fix buffer underflow when base64 decoding 0 length binaries The issue didn't cause problems under normal circumstances but ASAN tests caught it in JSON tests enabled in IMPALA-12927. Changed text parsing logic to skip base64 decoding for empty binaries. Also fixed Base64DecodeBufLen() with len=0 and added unit tests, though this function is not used with len=0 outside BE tests. Change-Id: I511cff8cec319d03d494a342f2cbb4a251cb893e Reviewed-on: http://gerrit.cloudera.org:8080/22855 Reviewed-by: Riza Suminto <riza.sumi...@cloudera.com> Reviewed-by: Zoltan Borok-Nagy <borokna...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/text-converter.inline.h M be/src/util/coding-util-test.cc M be/src/util/coding-util.cc 3 files changed, 17 insertions(+), 1 deletion(-) Approvals: Riza Suminto: Looks good to me, but someone else must approve Zoltan Borok-Nagy: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I511cff8cec319d03d494a342f2cbb4a251cb893e Gerrit-Change-Number: 22855 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
