Csaba Ringhofer has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/22855


Change subject: IMPALA-14030: Fix buffer underflow when base64 decoding 0 
length binaries
......................................................................

IMPALA-14030: Fix buffer underflow when base64 decoding 0 length binaries

The issue didn't cause problems under normal circumstances but ASAN
tests caught it in JSON tests enabled in IMPALA-12927.

Changed text parsing logic to skip base64 decoding for empty binaries.

Also fixed Base64DecodeBufLen() with len=0 and added unit tests, though
this function is not used with len=0 outside BE tests.

Change-Id: I511cff8cec319d03d494a342f2cbb4a251cb893e
---
M be/src/exec/text-converter.inline.h
M be/src/util/coding-util-test.cc
M be/src/util/coding-util.cc
3 files changed, 18 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/22855/1
--
To view, visit http://gerrit.cloudera.org:8080/22855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I511cff8cec319d03d494a342f2cbb4a251cb893e
Gerrit-Change-Number: 22855
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>

Reply via email to