Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22852 )
Change subject: IMPALA-14027: Implement HS2 NULL_TYPE using TStringValue ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/22852/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22852/1//COMMIT_MSG@7 PS1, Line 7: TStringVal > Here it says TStringVal, on L9 it's TStringValue. It would be better to be Done http://gerrit.cloudera.org:8080/#/c/22852/1//COMMIT_MSG@15 PS1, Line 15: he.hive.jdbc.Hive > Please fill in detail about when/how that was resolved. Also, are you refer I'm testing the repro scenario from IMPALA-914. Updated the commit message accodingly. http://gerrit.cloudera.org:8080/#/c/22852/1/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/22852/1/be/src/service/hs2-util.cc@163 PS1, Line 163: // It is actually not necessary to evaluate expr_eva > This doesn't seem necessary as we assume it that it is always null. I am ok Done http://gerrit.cloudera.org:8080/#/c/22852/1/fe/src/test/java/org/apache/impala/service/JdbcTest.java File fe/src/test/java/org/apache/impala/service/JdbcTest.java: http://gerrit.cloudera.org:8080/#/c/22852/1/fe/src/test/java/org/apache/impala/service/JdbcTest.java@604 PS1, Line 604: to be compatible with Hive > Is this part of the sentence still valid? I should say HiveServer2. Downstream, I see external HiveServer2 frontend return NULL type. http://gerrit.cloudera.org:8080/#/c/22852/1/tests/hs2/test_fetch.py File tests/hs2/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/22852/1/tests/hs2/test_fetch.py@245 PS1, Line 245: # Check that the expected type is NULL_TYPE (for compatibility with HiveServer2, > This comment should be updated. Done -- To view, visit http://gerrit.cloudera.org:8080/22852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I354110164b360013d9893f1eb4398c3418f80472 Gerrit-Change-Number: 22852 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 05 May 2025 16:11:08 +0000 Gerrit-HasComments: Yes
