Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22852 )
Change subject: IMPALA-14027: Implement HS2 NULL_TYPE using TStringVal ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22852/1/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/22852/1/be/src/service/hs2-util.cc@163 PS1, Line 163: BooleanVal val = expr_eval->GetBooleanVal(it.Get()); This doesn't seem necessary as we assume it that it is always null. I am ok with evaluating it to keep it consistent with other similar functions, but a comment could be added about this. -- To view, visit http://gerrit.cloudera.org:8080/22852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I354110164b360013d9893f1eb4398c3418f80472 Gerrit-Change-Number: 22852 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 05 May 2025 15:39:49 +0000 Gerrit-HasComments: Yes
