Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22816 )
Change subject: IMPALA-13829: Postpone catalog deleteLog GC for waitForHmsEvent requests ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/22816/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22816/4/be/src/catalog/catalog-server.cc@243 PS4, Line 243: DECLARE_int32(state_store_port); This is a duplicate line. http://gerrit.cloudera.org:8080/#/c/22816/4/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java File fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java: http://gerrit.cloudera.org:8080/#/c/22816/4/fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java@72 PS4, Line 72: oldest Isn't it actually the youngest topic update that is GC'ed, i.e. all topic updates before it (older than it) will also be GC'ed. http://gerrit.cloudera.org:8080/#/c/22816/4/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/22816/4/tests/metadata/test_event_processing.py@627 PS4, Line 627: < latest catalog version If I understand it correctly, this assumes the behaviour before this patch. I think we should mention that this is no longer the way Catalogd works, but it can be used to trigger the issue before this fix. Also applies to L642. http://gerrit.cloudera.org:8080/#/c/22816/4/tests/metadata/test_event_processing.py@633 PS4, Line 633: _ Optional: in my opinion, if we're not using the resulting lists, for loops communicate the intent of the code more clearly than list comprehensions. -- To view, visit http://gerrit.cloudera.org:8080/22816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2441440bca2b928205dd514047ba742a5e8bf05e Gerrit-Change-Number: 22816 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Apr 2025 14:59:27 +0000 Gerrit-HasComments: Yes
