Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22816 )
Change subject: IMPALA-13829: Postpone catalog deleteLog GC for waitForHmsEvent requests ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22816/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22816/2//COMMIT_MSG@33 PS2, Line 33: A new flag, catalog_delete_log_gc_frequency, is added for this. The : deleteLog GC happens in every N+1 (N=catalog_delete_log_gc_frequency) : topic updates. > Catalog updates will only be sent out when there are catalog changes (due t 4000s is roughly 1 hour. Are we OK with potential JVM heap growth caused by delayed deleteLog? I understand that this follows previous method by topic_update_log_gc_frequency, and I'm OK if we follow that method in this patch. However, would it be better if GC happen every topic update, but only GC log from 1 hour behind to avoid OOM? http://gerrit.cloudera.org:8080/#/c/22816/2/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/22816/2/tests/metadata/test_event_processing.py@626 PS2, Line 626: # the same event batch). We need more > It seems we don't need assertion here. If it fails, it raises an exception: Ack http://gerrit.cloudera.org:8080/#/c/22816/2/tests/metadata/test_event_processing.py@639 PS2, Line 639: > Assert that this is success? Nevermind. -- To view, visit http://gerrit.cloudera.org:8080/22816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2441440bca2b928205dd514047ba742a5e8bf05e Gerrit-Change-Number: 22816 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Apr 2025 14:15:15 +0000 Gerrit-HasComments: Yes
