Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22782 )
Change subject: IMPALA-13967: Move away from setting user parameter in execute ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22782/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22782/3/tests/common/impala_connection.py@971 PS3, Line 971: row = list() : for idx, val in enumerate(result_tuple): : row.append(self.__convert_result_value(val, self.column_types[idx])) : return '\t'.join(row) : : def __convert_result_value(self, val, col_type): : """Take a primitive value from a result tuple and its type and construct the string : that would have been returned via beeswax.""" : if val is None: : return 'NULL' : if type(val) == float: : # Same format as what Beeswax uses in the backend. : return "{:.16g}".format(val) : elif col_type == 'BOOLEAN': : # Beeswax return 'false' or 'true' for boolean column. : # HS2 return 'False' or 'True'. : return str(val).lower() > I assume this will get rebased on https://gerrit.cloudera.org/#/c/22785/ (o Yes, they will merge eventually. -- To view, visit http://gerrit.cloudera.org:8080/22782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20990d773f3471c129040cefcdff1c6d89ce87eb Gerrit-Change-Number: 22782 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 17:22:41 +0000 Gerrit-HasComments: Yes
