Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22782 )
Change subject: IMPALA-13967: Move away from setting user parameter in execute ...................................................................... Patch Set 3: Code-Review+1 (6 comments) Thanks for taking care of this Riza! I don't have any other additional comment. http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG@9 PS3, Line 9: has nit: have http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG@14 PS3, Line 14: allows nit: allow http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG@15 PS3, Line 15: test nit: tests http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG@16 PS3, Line 16: instantiate nit: instantiates http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG@18 PS3, Line 18: bug nit: bugs http://gerrit.cloudera.org:8080/#/c/22782/3//COMMIT_MSG@29 PS3, Line 29: remain nit: remains -- To view, visit http://gerrit.cloudera.org:8080/22782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20990d773f3471c129040cefcdff1c6d89ce87eb Gerrit-Change-Number: 22782 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 17:36:01 +0000 Gerrit-HasComments: Yes
