Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/22424/27//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22424/27//COMMIT_MSG@26 PS27, Line 26: --oauth_client_secret_cmd="cat password_file.txt" Why is this need to be a command and not simply a filename? --oauth_client_secret="password_file.txt" Is there any command other than 'cat' to use? If yes, please put an example in commit message. http://gerrit.cloudera.org:8080/#/c/22424/27/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/27/tests/custom_cluster/test_shell_jwt_auth.py@217 PS27, Line 217: '--oauth_mock_response_cmd', : 'cat {0}'.format(TestImpalaShellJWTAuth.OAUTH_VALID_PAYLOAD) If this is just for mocking, can this simply be a filename instead of 'cat filename'? -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 27 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 19:12:40 +0000 Gerrit-HasComments: Yes
