Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 25: (2 comments) http://gerrit.cloudera.org:8080/#/c/22424/25/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/25/shell/impala_shell.py@1859 PS25, Line 1859: def oauth_get_access_token(self): This function needs a help string explaining it's purpose. http://gerrit.cloudera.org:8080/#/c/22424/25/shell/impala_shell.py@1881 PS25, Line 1881: audience Will the audience always be "https://{{oauthserver}}/api/v2/"; or do we need to make it configurable? -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 25 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 16:35:19 +0000 Gerrit-HasComments: Yes
