Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py File tests/custom_cluster/test_metadata_no_events_processing.py: http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py@28 PS2, Line 28: def default_test_protocol(cls): Are we going to remove this when everything is switched over to HS2? http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py File tests/custom_cluster/test_stats_extrapolation.py: http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py@60 PS2, Line 60: col_names = [col_name for col_name in table_stats.column_labels] Previously we had a transformation, we called ".upper()" on the name. Do we not need it anymore? Do we need to create a new list here, couldn't we have col_names = table_stats.column_labels ? AFAICS we're not mutating the list. Applies also to L66. http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py File tests/metadata/test_stats_extrapolation.py: http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@78 PS2, Line 78: Although I find this indentation logical, our style guide says we should use +4 spaces for continuation lines. Same on L135. http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@147 PS2, Line 147: col_names = [col_name for col_name in actual.column_labels] Same as before, don't we need the ".upper()' call? If not, we can have col_names = actual.column_labels . Applies to L175 too. -- To view, visit http://gerrit.cloudera.org:8080/22776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee Gerrit-Change-Number: 22776 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Apr 2025 14:51:31 +0000 Gerrit-HasComments: Yes
