Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py File tests/custom_cluster/test_metadata_no_events_processing.py: http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py@28 PS2, Line 28: def default_test_protocol(cls): > Are we going to remove this when everything is switched over to HS2? Yes, that is the plan. http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py File tests/custom_cluster/test_stats_extrapolation.py: http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py@60 PS2, Line 60: col_names = [col_name for col_name in table_stats.column_labels] > Previously we had a transformation, we called ".upper()" on the name. Do we Not needed. It is already in uppercase. https://github.com/apache/impala/blob/50a98dce46fd337461f67b98979fece95c7bf738/tests/common/impala_connection.py#L906 Even in beeswax. https://github.com/apache/impala/blob/50a98dce46fd337461f67b98979fece95c7bf738/tests/beeswax/impala_beeswax.py#L87 http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py File tests/metadata/test_stats_extrapolation.py: http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@78 PS2, Line 78: create table {0 > Although I find this indentation logical, our style guide says we should us Done http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@147 PS2, Line 147: assert len(actual.column_labels) == len(expected.column_labels) > Same as before, don't we need the ".upper()' call? If not, we can have Answered here: https://gerrit.cloudera.org/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py#60 -- To view, visit http://gerrit.cloudera.org:8080/22776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee Gerrit-Change-Number: 22776 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Apr 2025 15:04:13 +0000 Gerrit-HasComments: Yes
