Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22770 )
Change subject: IMPALA-13954: Validate num inserted rows via NumModifiedRows counter ...................................................................... IMPALA-13954: Validate num inserted rows via NumModifiedRows counter This patch changes the way test validate num inserted rows from checking the beeswax-specific result to checking NumModifiedRows counter from query profile. Remove skiping over hs2 protocol in test_chars.py and refactor test_date_queries.py a bit to reduce test skiping. Added HS2_TYPES in tests that requires it and fix some flake8 issues. Testing: Run and pass all affected tests. Change-Id: I96eae9967298f75b2c9e4d0662fcd4a62bf5fffc Reviewed-on: http://gerrit.cloudera.org:8080/22770 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Riza Suminto <riza.sumi...@cloudera.com> --- M testdata/workloads/functional-query/queries/QueryTest/alter-table.test M testdata/workloads/functional-query/queries/QueryTest/chars-tmp-tables.test M testdata/workloads/functional-query/queries/QueryTest/chars-values-stmt-lossy-char-padding.test M testdata/workloads/functional-query/queries/QueryTest/chars-values-stmt-no-lossy-char-padding.test M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test M testdata/workloads/functional-query/queries/QueryTest/create-table.test M testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test M testdata/workloads/functional-query/queries/QueryTest/decimal-insert-overflow-exprs.test M testdata/workloads/functional-query/queries/QueryTest/delimited-text.test M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test M testdata/workloads/functional-query/queries/QueryTest/hbase-inserts.test M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-insert.test M testdata/workloads/functional-query/queries/QueryTest/insert.test M testdata/workloads/functional-query/queries/QueryTest/insert_null.test M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test M testdata/workloads/functional-query/queries/QueryTest/parquet-error-propagation-race.test M testdata/workloads/tpcds-insert/queries/expr-insert.test M testdata/workloads/tpch/queries/insert_parquet.test M tests/query_test/test_chars.py M tests/query_test/test_date_queries.py 22 files changed, 196 insertions(+), 168 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Riza Suminto: Verified -- To view, visit http://gerrit.cloudera.org:8080/22770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I96eae9967298f75b2c9e4d0662fcd4a62bf5fffc Gerrit-Change-Number: 22770 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
