Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22770 )
Change subject: IMPALA-13954: Validate num inserted rows via NumModifiedRows counter ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+2 > > Thanks Riza! Do I understand it correctly that some of the tests, e.g. > decimal-insert-overflow-exprs.test are still only run with Beeswax, and we > are planning to transition to HS2 as the default protocol later? That is correct. This patch mainly focus on changing the num row validation, and not migrating to hs2 yet. Thanks for the review! -- To view, visit http://gerrit.cloudera.org:8080/22770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96eae9967298f75b2c9e4d0662fcd4a62bf5fffc Gerrit-Change-Number: 22770 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 14:31:56 +0000 Gerrit-HasComments: No
