Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22746 )
Change subject: IMPALA-13873: Missing equivalence conjunct in aggregation node with inline views ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22746/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22746/4//COMMIT_MSG@39 PS4, Line 39: This may happen if a conjunct cannot be pushed into all operands of a > The predicate "t.b = t.min_b" couldn't be bound to the tuple of "u1", which That helps connect the dots. From your example, it appears that an extra union node is placed above the final aggregate to evaluate the predicate. The lower aggregate would probably need an additional union node added allow pushing the conjunct into the branch. Just be careful in the commit message and comments to explain that this is more of an implementation limitation and that the new logic is simply working within the constraints of the materialization logic. -- To view, visit http://gerrit.cloudera.org:8080/22746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67a59cd96d83181ce249fd6ca141906f549a09b3 Gerrit-Change-Number: 22746 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 20:30:27 +0000 Gerrit-HasComments: Yes
