Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22746 )
Change subject: IMPALA-13873: Missing equivalence conjunct in aggregation node with inline views ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22746/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/22746/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@136 PS4, Line 136: // Normally, predicates bound by a grouping slot produced by a SlotRef grouping expr are Description should not be specific to grouping slots. Better to say that conjuncts must be kept if they can't be pushed into every arm and give a concrete example of when this would be nececessary. http://gerrit.cloudera.org:8080/#/c/22746/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@1029 PS4, Line 1029: if (!keepConjuncts_) { Conjuncts should be flagged on an individual basis so they can be separately removed if they qualify. -- To view, visit http://gerrit.cloudera.org:8080/22746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67a59cd96d83181ce249fd6ca141906f549a09b3 Gerrit-Change-Number: 22746 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 08 Apr 2025 12:43:29 +0000 Gerrit-HasComments: Yes
