Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21337 )

Change subject: IMPALA-12922: Make batch_sizes an optional test dimension
......................................................................


Patch Set 5:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/21337/5/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/21337/5/tests/common/test_dimensions.py@308
PS5, Line 308: s
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21337/5/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

http://gerrit.cloudera.org:8080/#/c/21337/5/tests/query_test/test_hdfs_caching.py@81
PS5, Line 81: (
flake8: E275 missing whitespace after keyword



--
To view, visit http://gerrit.cloudera.org:8080/21337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39afa892ecf78b717686d59d7fdd1877a64d609f
Gerrit-Change-Number: 21337
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Mar 2025 23:46:37 +0000
Gerrit-HasComments: Yes

Reply via email to