Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21337
to look at the new patch set (#5).
Change subject: IMPALA-12922: Make batch_sizes an optional test dimension
......................................................................
IMPALA-12922: Make batch_sizes an optional test dimension
Before this patch, BATCH_SIZE option is a required parameter with
default value of [0] in create_exec_option_dimension. However, only few
end-to-end and custom cluster tests actively parameterize BATCH_SIZE
option to non-default value. This makes test identifiers unnecessarily
long if 'vector' fixture is being used.
This patch makes batch_sizes an optional parameter in
create_exec_option_dimension, just like sync_ddl. Replace batch_size ==
0 constraint with explicit batch size dimension via
add_default_batch_size_dimension, add_exec_option_dimension,
add_mandatory_exec_option_dimension, or default_batch_size_constraint.
If batch_sizes parameter is changed to non-optional in the future, the
modified tests will assert that batch_size option is declared in an
inconsistent way. Together, they reduce the length of test identifiers
in many EE and custom cluster tests.
No test count changed in exhaustive mode. But in core exploration mode,
4 new test permutation shows up in test_result_spooling.py after their
test dimension refactored.
Testing:
- Pass core end-to-end and custom cluster tests.
Change-Id: I39afa892ecf78b717686d59d7fdd1877a64d609f
---
M common/thrift/Query.thrift
M tests/common/custom_cluster_test_suite.py
M tests/common/impala_test_suite.py
M tests/common/test_dimensions.py
M tests/common/test_vector.py
M tests/custom_cluster/test_kudu.py
M tests/experiments/test_targeted_perf.py
M tests/failure/test_failpoints.py
M tests/metadata/test_ddl_base.py
M tests/metadata/test_explain.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_recover_partitions.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_analytic_tpcds.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_datastream_sender.py
M tests/query_test/test_fetch.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_hdfs_caching.py
M tests/query_test/test_limit.py
M tests/query_test/test_mt_dop.py
M tests/query_test/test_queries.py
M tests/query_test/test_query_mem_limit.py
M tests/query_test/test_result_spooling.py
M tests/query_test/test_rows_availability.py
M tests/query_test/test_tpcds_queries.py
26 files changed, 198 insertions(+), 146 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/21337/5
--
To view, visit http://gerrit.cloudera.org:8080/21337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39afa892ecf78b717686d59d7fdd1877a64d609f
Gerrit-Change-Number: 21337
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
