Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22634 )
Change subject: IMPALA-13850: Wait until CatalogD active before resetting metadata ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22634/2/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22634/2/be/src/catalog/catalog-server.cc@727 PS2, Line 727: TriggerResetMetadataLocked(); > Once catalogd becomes active, there should be no timeout within itself. So it's another issue but due to the same cause that CatalogServiceCatalog.reset() could run slow. When the active catalogd crash, the standby catalogd might take a long time to become active. During this step, we need to make sure it's still healthy. http://gerrit.cloudera.org:8080/#/c/22634/2/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/22634/2/tests/custom_cluster/test_catalogd_ha.py@179 PS2, Line 179: catalogd_service_2.wait_for_metric_value( : "catalog-server.active-status", expected_value=True, timeout=30) Just curious, what if coordinator runs a DDL before this? Will it fail? -- To view, visit http://gerrit.cloudera.org:8080/22634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc66dcccedb306ff11893f2916ee5ee6a3efc1 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Mar 2025 08:16:10 +0000 Gerrit-HasComments: Yes