Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22634 )
Change subject: IMPALA-13850 (part 1): Wait until CatalogD active before resetting ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/22634/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22634/5//COMMIT_MSG@23 PS5, Line 23: TriggerResetMetadata that monitor and trigger this initial reset > > It appears to be the case. Ack http://gerrit.cloudera.org:8080/#/c/22634/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22634/7//COMMIT_MSG@20 PS7, Line 20: The later : prerequisite is to ensure that all coordinators are not blocked waiting : for full topic update. > I think local catalog mode is fine since queries will be blocked in fetchin Ack http://gerrit.cloudera.org:8080/#/c/22634/8/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22634/8/be/src/catalog/catalog-server.cc@766 PS8, Line 766: // Run ResetMetadata without holding 'catalog_lock_' so that it does not block : // gathering thread > I think they will run sequentially due to the versionLock_ in CatalogServic Clarified the comment. http://gerrit.cloudera.org:8080/#/c/22634/8/be/src/catalog/catalog-server.cc@768 PS8, Line 768: versionLock_.writeLock() in JVM. > This sounds like a user triggered command. Let's use "catalog invalidation" Done http://gerrit.cloudera.org:8080/#/c/22634/8/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/22634/8/tests/common/impala_cluster.py@249 PS8, Line 249: if flags['stress_catalog_init_delay_ms'] != '0': > I used to writing "--use_local_catalog" instead of "--use_local_catalog=tru Changed this to check the '/varz?json' page. I think it is more reliable. -- To view, visit http://gerrit.cloudera.org:8080/22634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc66dcccedb306ff11893f2916ee5ee6a3efc1 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 17:43:31 +0000 Gerrit-HasComments: Yes
