Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22724 )
Change subject: IMPALA-13925: Deflake TestFrontendConnectionLimit ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22724/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22724/2/tests/common/impala_test_suite.py@258 PS2, Line 258: # Create a Hive Metastore Client (used for executing some test SETUP steps : metastore_host, metastore_port = pytest.config.option.metastore_server.split(':') : trans_type = 'buffered' : if pytest.config.option.use_kerberos: : trans_type = 'kerberos' : cls.hive_transport = create_transport( : host=metastore_host, : port=metastore_port, : service=pytest.config.option.hive_service_name, : transport_type=trans_type) : protocol = TBinaryProtocol.TBinaryProtocol(cls.hive_transport) : cls.hive_client = ThriftHiveMetastore.Client(protocol) : cls.hive_transport.open() It should be possible to move this done. I'll do it in next patch set. http://gerrit.cloudera.org:8080/#/c/22724/1/tests/custom_cluster/test_frontend_connection_limit.py File tests/custom_cluster/test_frontend_connection_limit.py: http://gerrit.cloudera.org:8080/#/c/22724/1/tests/custom_cluster/test_frontend_connection_limit.py@53 PS1, Line 53: ytest.mark.execute_serially > Or maybe we just add some comments to explain why close_impala_clients() is On second thought, I've seen several tests that does not actually require default clients to exist. So having a way to control it during setup_class() should be helpful. Addressed this in patch set 2. -- To view, visit http://gerrit.cloudera.org:8080/22724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53c6760f5e3734397746b5a228345c9df38eabcb Gerrit-Change-Number: 22724 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 23:36:42 +0000 Gerrit-HasComments: Yes
