Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22724 )
Change subject: IMPALA-13925: Deflake TestFrontendConnectionLimit ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22724/1/tests/custom_cluster/test_frontend_connection_limit.py File tests/custom_cluster/test_frontend_connection_limit.py: http://gerrit.cloudera.org:8080/#/c/22724/1/tests/custom_cluster/test_frontend_connection_limit.py@53 PS1, Line 53: self.close_impala_clients() Would it be better to put it to a setup_method() as there are no other methods in this class and put some comments to explain it? def setup_method(self): super(TestFrontendConnectionLimit, self).setup_method() # Some comments to explain why we need it self.close_impala_clients() -- To view, visit http://gerrit.cloudera.org:8080/22724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53c6760f5e3734397746b5a228345c9df38eabcb Gerrit-Change-Number: 22724 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 22:32:42 +0000 Gerrit-HasComments: Yes
