Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22571 )
Change subject: IMPALA-13684: Improve waitForHmsEvent() to only wait for related events ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4363 PS10, Line 4363: LOG.warn("Failed to check and expand views. Query might see sale metadata", e); stale http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4452 PS10, Line 4452: reloadTable(tbl, /*unused*/"reason", Should we set reason to "Reference from view <viewname>"? http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4483 PS10, Line 4483: LOG.warn("Unable to expand view {}.{} since it's modified concurrently", Vague message. If this is expected to be a view we should be more concise about the change. Also, why only a warning? http://gerrit.cloudera.org:8080/#/c/22571/10/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4523 PS10, Line 4523: LOG.warn("Illegal table name found in view {}: {}", view.getFullName(), strs); Why only a warning? -- To view, visit http://gerrit.cloudera.org:8080/22571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic033b7e197cd19505653c3ff80c4857cc474bcfc Gerrit-Change-Number: 22571 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 01 Apr 2025 14:22:24 +0000 Gerrit-HasComments: Yes
