Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 34: Code-Review+1 (3 comments) Works for me. http://gerrit.cloudera.org:8080/#/c/22319/31/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22319/31/fe/src/main/java/org/apache/impala/service/Frontend.java@2319 PS31, Line 2319: LOG.info("Calcite planner failed: ", e); > Done Ack http://gerrit.cloudera.org:8080/#/c/22319/31/fe/src/main/java/org/apache/impala/service/Frontend.java@3577 PS31, Line 3577: return null; > Done Ack http://gerrit.cloudera.org:8080/#/c/22319/31/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22319/31/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@112 PS31, Line 112: } catch (UnsupportedFeatureException e) { > This is actually code that's going away soon, but not immediately. The cod Ack -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 34 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Mar 2025 23:45:46 +0000 Gerrit-HasComments: Yes