Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 33: (2 comments) http://gerrit.cloudera.org:8080/#/c/22319/33/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/22319/33/common/thrift/Query.thrift@778 PS33, Line 778: // See comment in ImpalaService.thrift : 192: optional bool use_calcite_planner = false; Please check ENABLED_RUNTIME_FILTER_TYPES option. In similar manner, we can specify this as an option of list value, specifying the order of SQL compiler priority. Something like this: SET ENABLED_SQL_COMPILER="CALCITE,CLASSIC"; If I do just SET ENABLED_SQL_COMPILER="CALCITE"; Then query compilation should not fallback to classic planner and fail upon compile failure. What do you think? http://gerrit.cloudera.org:8080/#/c/22319/33/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22319/33/fe/src/main/java/org/apache/impala/service/Frontend.java@3559 PS33, Line 3559: private CompilerFactory getCalciteCompilerFactory Add @Nullable annotation. -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 33 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Mar 2025 21:14:40 +0000 Gerrit-HasComments: Yes
