Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22330 )
Change subject: IMPALA-11980 (part 2): Fix absolute import issues for impala_shell ...................................................................... Patch Set 9: (62 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/ImpalaHttpClient.py@47 PS9, Line 47: class ImpalaHttpClient(TTransportBase): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/ImpalaHttpClient.py@188 PS9, Line 188: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/ImpalaHttpClient.py@200 PS9, Line 200: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/ImpalaHttpClient.py@229 PS9, Line 229: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/TSSLSocketWithWildcardSAN.py File shell/impala_shell/TSSLSocketWithWildcardSAN.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/TSSLSocketWithWildcardSAN.py@27 PS9, Line 27: class CertificateError(ValueError): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/TSSLSocketWithWildcardSAN.py@31 PS9, Line 31: class TSSLSocketWithWildcardSAN(TSSLSocket.TSSLSocket): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@100 PS9, Line 100: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@210 PS9, Line 210: p flake8: U100 Unused argument 'protocol' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@256 PS9, Line 256: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@256 PS9, Line 256: s flake8: U100 Unused argument 'set_query_options' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@264 PS9, Line 264: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@297 PS9, Line 297: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@303 PS9, Line 303: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@307 PS9, Line 307: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@307 PS9, Line 307: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@311 PS9, Line 311: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@324 PS9, Line 324: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@332 PS9, Line 332: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@338 PS9, Line 338: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@344 PS9, Line 344: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@353 PS9, Line 353: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@362 PS9, Line 362: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@362 PS9, Line 362: w flake8: U100 Unused argument 'warn' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@834 PS9, Line 834: c flake8: U100 Unused argument 'column_value_getters' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@976 PS9, Line 976: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@1220 PS9, Line 1220: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@1223 PS9, Line 1223: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@1226 PS9, Line 1226: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@1396 PS9, Line 1396: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_client.py@1512 PS9, Line 1512: ( flake8: E275 missing whitespace after keyword http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@346 PS9, Line 346: t flake8: U100 Unused argument 'type' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@346 PS9, Line 346: v flake8: U100 Unused argument 'value' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@346 PS9, Line 346: t flake8: U100 Unused argument 'traceback' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@697 PS9, Line 697: s flake8: U100 Unused argument 'signal' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@697 PS9, Line 697: f flake8: U100 Unused argument 'frame' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@805 PS9, Line 805: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@968 PS9, Line 968: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@1503 PS9, Line 1503: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@1622 PS9, Line 1622: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@1662 PS9, Line 1662: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@1822 PS9, Line 1822: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@1827 PS9, Line 1827: i flake8: U100 Unused argument 'ignored' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@2260 PS9, Line 2260: e flake8: F841 local variable 'e' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/impala_shell.py@2303 PS9, Line 2303: i flake8: F401 'thrift.protocol.fastbinary' imported but unused http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/option_parser.py File shell/impala_shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/option_parser.py@273 PS9, Line 273: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/option_parser.py@274 PS9, Line 274: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/option_parser.py@275 PS9, Line 275: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/option_parser.py@381 PS9, Line 381: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/option_parser.py@386 PS9, Line 386: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/shell_output.py File shell/impala_shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/shell_output.py@41 PS9, Line 41: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/shell_output.py@45 PS9, Line 45: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/shell_output.py@106 PS9, Line 106: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/shell_output.py@135 PS9, Line 135: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/shell_output.py@137 PS9, Line 137: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/value_converter.py File shell/impala_shell/value_converter.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/value_converter.py@27 PS9, Line 27: v flake8: U100 Unused argument 'value' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/impala_shell/value_converter.py@30 PS9, Line 30: f flake8: U100 Unused argument 'format_specification' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py File shell/setup.py: http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py@97 PS9, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py@97 PS9, Line 97: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py@97 PS9, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py@97 PS9, Line 97: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py@97 PS9, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/9/shell/setup.py@105 PS9, Line 105: \ flake8: W605 invalid escape sequence '\d' -- To view, visit http://gerrit.cloudera.org:8080/22330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica75a24fa6bcb78999b9b6f4f4356951b81c3124 Gerrit-Change-Number: 22330 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Mar 2025 18:17:07 +0000 Gerrit-HasComments: Yes
