Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22330 )
Change subject: IMPALA-11980 (part 2): Fix absolute import issues for impala_shell ...................................................................... Patch Set 7: (62 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/ImpalaHttpClient.py@47 PS7, Line 47: class ImpalaHttpClient(TTransportBase): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/ImpalaHttpClient.py@188 PS7, Line 188: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/ImpalaHttpClient.py@200 PS7, Line 200: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/ImpalaHttpClient.py@229 PS7, Line 229: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/TSSLSocketWithWildcardSAN.py File shell/impala_shell/TSSLSocketWithWildcardSAN.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/TSSLSocketWithWildcardSAN.py@27 PS7, Line 27: class CertificateError(ValueError): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/TSSLSocketWithWildcardSAN.py@31 PS7, Line 31: class TSSLSocketWithWildcardSAN(TSSLSocket.TSSLSocket): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@100 PS7, Line 100: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@361 PS7, Line 361: p flake8: U100 Unused argument 'protocol' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@407 PS7, Line 407: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@407 PS7, Line 407: s flake8: U100 Unused argument 'set_query_options' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@415 PS7, Line 415: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@448 PS7, Line 448: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@454 PS7, Line 454: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@458 PS7, Line 458: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@458 PS7, Line 458: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@462 PS7, Line 462: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@475 PS7, Line 475: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@483 PS7, Line 483: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@489 PS7, Line 489: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@495 PS7, Line 495: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@504 PS7, Line 504: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@513 PS7, Line 513: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@513 PS7, Line 513: w flake8: U100 Unused argument 'warn' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@985 PS7, Line 985: c flake8: U100 Unused argument 'column_value_getters' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@1127 PS7, Line 1127: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@1371 PS7, Line 1371: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@1374 PS7, Line 1374: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@1377 PS7, Line 1377: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@1547 PS7, Line 1547: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_client.py@1663 PS7, Line 1663: ( flake8: E275 missing whitespace after keyword http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@346 PS7, Line 346: t flake8: U100 Unused argument 'type' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@346 PS7, Line 346: v flake8: U100 Unused argument 'value' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@346 PS7, Line 346: t flake8: U100 Unused argument 'traceback' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@697 PS7, Line 697: s flake8: U100 Unused argument 'signal' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@697 PS7, Line 697: f flake8: U100 Unused argument 'frame' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@805 PS7, Line 805: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@968 PS7, Line 968: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@1503 PS7, Line 1503: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@1622 PS7, Line 1622: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@1662 PS7, Line 1662: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@1822 PS7, Line 1822: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@1827 PS7, Line 1827: i flake8: U100 Unused argument 'ignored' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@2260 PS7, Line 2260: e flake8: F841 local variable 'e' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/impala_shell.py@2303 PS7, Line 2303: i flake8: F401 'thrift.protocol.fastbinary' imported but unused http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/option_parser.py File shell/impala_shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/option_parser.py@273 PS7, Line 273: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/option_parser.py@274 PS7, Line 274: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/option_parser.py@275 PS7, Line 275: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/option_parser.py@381 PS7, Line 381: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/option_parser.py@386 PS7, Line 386: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/shell_output.py File shell/impala_shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/shell_output.py@41 PS7, Line 41: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/shell_output.py@45 PS7, Line 45: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/shell_output.py@106 PS7, Line 106: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/shell_output.py@135 PS7, Line 135: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/shell_output.py@137 PS7, Line 137: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/value_converter.py File shell/impala_shell/value_converter.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/value_converter.py@27 PS7, Line 27: v flake8: U100 Unused argument 'value' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/impala_shell/value_converter.py@30 PS7, Line 30: f flake8: U100 Unused argument 'format_specification' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py File shell/setup.py: http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py@97 PS7, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py@97 PS7, Line 97: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py@97 PS7, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py@97 PS7, Line 97: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py@97 PS7, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/7/shell/setup.py@105 PS7, Line 105: \ flake8: W605 invalid escape sequence '\d' -- To view, visit http://gerrit.cloudera.org:8080/22330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica75a24fa6bcb78999b9b6f4f4356951b81c3124 Gerrit-Change-Number: 22330 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 18:10:35 +0000 Gerrit-HasComments: Yes
