Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22711 )
Change subject: IMPALA-13885: (addendum) Add Missing Double Quotes to Log Messages ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22711/2/be/src/service/workload-management-worker.cc File be/src/service/workload-management-worker.cc: http://gerrit.cloudera.org:8080/#/c/22711/2/be/src/service/workload-management-worker.cc@800 PS2, Line 800: PrettyPrinter::PrintBytes(sql.size()) > As long as value does not contain whitespace, I don't think it is necessary pretty printing bytes inserts a space before the units: bytes="6.11 KB" I like having the double quotes for key-value pairs since it makes it easier to differentiate where one key-value pair ends and another begins and its consistent. I think I just talked myself into adding double quotes around record_count too so everything is completely consistent. Sample log message: I0328 14:21:00.385085 2380412 workload-management-worker.cc:806] c748e7c938394dc9:f63162aa00000000] wrote completed queries table="sys.impala_query_log" record_count=3 bytes="6.11 KB" gather_time="666.758us" exec_time="269.840ms" query_id="c748e7c938394dc9:f63162aa00000000" -- To view, visit http://gerrit.cloudera.org:8080/22711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70111fb5726fd2623aa76168d44ecfacae90fa83 Gerrit-Change-Number: 22711 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Mar 2025 21:29:46 +0000 Gerrit-HasComments: Yes
