Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22711 )
Change subject: IMPALA-13885: (addendum) Add Missing Double Quotes to Log Messages ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22711/2/be/src/service/workload-management-worker.cc File be/src/service/workload-management-worker.cc: http://gerrit.cloudera.org:8080/#/c/22711/2/be/src/service/workload-management-worker.cc@800 PS2, Line 800: PrettyPrinter::PrintBytes(sql.size()) As long as value does not contain whitespace, I don't think it is necessary to quote. Only bytes here that might have space between value and unit. CatalogD choose not to pretty print bytes like this: Collected update: 1:DATABASE:functional_seq_record_snap, version=1477, original size=234, compressed size=186 -- To view, visit http://gerrit.cloudera.org:8080/22711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70111fb5726fd2623aa76168d44ecfacae90fa83 Gerrit-Change-Number: 22711 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Mar 2025 19:38:30 +0000 Gerrit-HasComments: Yes
